SILKIT-1896: Fix start of registry for Windows system service #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Windows service start path was using the wrong URI variable (listenUri from command line instead of configuredListenUri extracted from the sanitized configuration). The fix refactors the code to use a single lambda function for both Windows service and non-service execution paths.
Key Changes:
- Introduces a lambda
callStartRegistrythat captures the correctconfiguredListenUriand other parameters - Updates the Windows service path to use this lambda (fixing the original bug)
- Refactors the non-Windows service path to use the same lambda for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Becker, Lukas <[email protected]>
VLukasBecker
force-pushed
the
silkit-1896_registry_service_limited_to_port_8500
branch
from
b895b2a to
ef95846
Compare
VLukasBecker
deleted the
silkit-1896_registry_service_limited_to_port_8500
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Description
Developer checklist (address before review)